-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_nightly_version.sh script #9310
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/usr/bin/env bash | ||
|
||
#------------------------------------------------------------------------------ | ||
# Prints the exact version string that would be used to describe a nightly | ||
# build of the compiler. | ||
# | ||
# The documentation for solidity is hosted at: | ||
# | ||
# https://solidity.readthedocs.org | ||
# | ||
# ------------------------------------------------------------------------------ | ||
# This file is part of solidity. | ||
# | ||
# solidity is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# solidity is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with solidity. If not, see <http://www.gnu.org/licenses/> | ||
# | ||
# (c) 2017 solidity contributors. | ||
#------------------------------------------------------------------------------ | ||
|
||
set -e | ||
|
||
script_dir="$(dirname "$0")" | ||
|
||
solidity_version=$("${script_dir}/get_version.sh") | ||
last_commit_timestamp=$(git log -1 --date=iso --format=%ad HEAD) | ||
last_commit_date=$(date --date="$last_commit_timestamp" --utc +%Y.%-m.%-d) | ||
last_commit_hash=$(git rev-parse --short=8 HEAD) | ||
|
||
echo "v${solidity_version}-nightly.${last_commit_date}+commit.${last_commit_hash}" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's here because it's also in get_version.sh ? I'm not entirely sure why it's in there and why it should be in here - feels like a rather random piece of information to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed out of place to me too but I've seen it used in several other files (e.g. build_emscripten.sh or docs.sh) so I thought it was a deliberate convention. Should I remove it?
Docstrings and license comments are a mess in scripts anyway. Some have them like this, some do it differently, some do not have them at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. I'd say we can remove it here, since it seems rather weird - and maybe we should bring it up quickly in a meeting and decide on a convention for all the scripts and unify them in that regard... not that any of this is all that important, but still :-).
(we can do that independently of this pr, though, no need to stall)