get_nightly_version.sh script #9310
Conversation
cameel
force-pushed
the
get-nightly-version-script
branch
from
c2f9fd7 to
67ea193
Compare
| # | ||
| # The documentation for solidity is hosted at: | ||
| # | ||
| # https://solidity.readthedocs.org |
There was a problem hiding this comment.
I guess that's here because it's also in get_version.sh ? I'm not entirely sure why it's in there and why it should be in here - feels like a rather random piece of information to me...
There was a problem hiding this comment.
Seemed out of place to me too but I've seen it used in several other files (e.g. build_emscripten.sh or docs.sh) so I thought it was a deliberate convention. Should I remove it?
Docstrings and license comments are a mess in scripts anyway. Some have them like this, some do it differently, some do not have them at all.
There was a problem hiding this comment.
Yeah.. I'd say we can remove it here, since it seems rather weird - and maybe we should bring it up quickly in a meeting and decide on a convention for all the scripts and unify them in that regard... not that any of this is all that important, but still :-).
(we can do that independently of this pr, though, no need to stall)
Part of #9258.
Part of the Github action for building nightlies, extracted into a separate script as suggested by @ekpyron in ethereum/solc-bin#29 (comment).