Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5725: Move to Final #7543

Closed
wants to merge 54 commits into from
Closed

Update EIP-5725: Move to Final #7543

wants to merge 54 commits into from

Conversation

DeFiFoFum
Copy link
Contributor

  • Last Call ends on September 5th, 2023 at which point this can be merged into master and a PR into ethereum/EIPs can be created for the Final draft.

Apegurus and others added 30 commits September 27, 2022 03:09
@Apegurus
Merge pull request #1 from ethereum/master
5188f6f 
Update
@Apegurus
Merge branch 'ethereum:master' into master
89934f8
@Apegurus
chore: Commit draft EIP
70bb638
@Apegurus
chore: ERC to EIP and add EIP number
bfc1e1f
@Apegurus
refactor: EIP Validator changes
1d9961a
@Apegurus
refactor: Relative EIP linking
81feac0
@JorgeAtPaladin
chore: updated author, discussions-to and removed various links
e051390
@JorgeAtPaladin
chore: Moved reference implementation to assets
11e64dc
@JorgeAtPaladin
chore: removed invalid EIP sections
3006271
@Apegurus
Merge pull request #3 from JorgeAtPaladin/draft
48415ba 
Fixed eipw errors
@DeFiFoFum @SamWilsn
refactor: Remove comments from EIP-5725
068abab 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@DeFiFoFum
refactor: Update SPDX license to CC0-1.0
3a8ee84
@DeFiFoFum
refactor: Rename IVestingNFT to IERC5725
761abc6
@DeFiFoFum
feat: Add EIP-5725 assets README
f15a541
@DeFiFoFum
Merge branch 'draft' into rebrand/ERC5725
4cb049c
@DeFiFoFum
fix: Links
1118b8d
@DeFiFoFum
fix: Remove EIP-5725 header
f89cd06
@Apegurus @SamWilsn
Apply suggestions from code review
3781d99 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@DeFiFoFum
Merge pull request #4 from ApeSwapFinance/rebrand/ERC5725
c62aebe 
Rename IVestingNFT to IERC5725
@DeFiFoFum
refactor: Remove return value from claim()
f84d07c
@DeFiFoFum
fix: EIP-N reference
6b60f17
@Apegurus @SamWilsn
Update EIPS/eip-5725.md
a491393 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@Apegurus
refactor: Consistent style and event description
3b5e30a
@Apegurus
refactor: Implement new formatting lint recommendations
23246ed
@DeFiFoFum
refactor: Improve Rationale section
6331c89
@Apegurus
Merge pull request #5 from ApeSwapFinance/dev
aa09fae 
refactor: Consistent style and event description
@Apegurus
fix: MD linter errors
1596f2e
@DeFiFoFum
fix: Return value formatting
b1c8c4e
@DeFiFoFum
Merge branch 'dev' into draft
4a2437a
@DeFiFoFum
Merge pull request #2 from ApeSwapFinance/draft
6ec61de 
chore: Commit draft EIP
DeFiFoFum and others added 21 commits February 23, 2023 17:41
@DeFiFoFum
Merge branch 'ethereum:master' into upstream/master
c4867ce
@DeFiFoFum
Merge branch 'ethereum:master' into master
3618311
@DeFiFoFum
fix: lint
61f7f7f
@DeFiFoFum
Merge branch 'master' of github.com:ApeSwapFinance/EIPs
12d7411
@DeFiFoFum
fix: EIP -> ERC
e07bf4f
@DeFiFoFum
Merge branch 'ethereum:master' into master
e6f7a25
@DeFiFoFum
refactor: Update 5725 with proper token vesting support
041ccfc
@DeFiFoFum
Draft -> Review
dc91010
@DeFiFoFum
Merge branch 'ethereum:master' into master
83f0356
@DeFiFoFum
Merge branch 'ethereum:master' into master
badb449
@DeFiFoFum
Update EIP-5725: Move to Last Call
f547d05
@DeFiFoFum
Update EIP-5725: Add last-call-deadline
14e2d4c
@DeFiFoFum
Merge branch 'ethereum:master' into master
9f8b190
@DeFiFoFum
Merge branch 'master' into master
8429c6b
@Elliott-Green
[feat] Add allowance feature to EIP-5725
617f6fc
@Elliott-Green
[chore] change ERC5725.sol license to CC0-1.0
a5544a3
@Elliott-Green
[chore] resolve walidator linter
14cf3aa
@DeFiFoFum
Merge pull request #6 from Elliott-Green/master
b4dcce3 
[feat] Add allowance feature to EIP-5725
@DeFiFoFum @SamWilsn
refactor: Last call to 2023-09-05
0326e57 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@DeFiFoFum
chore: Resolve review comments
1e41272
@DeFiFoFum
Update EIP-5725: Move to Final
63c24dc
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-erc labels Aug 30, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 30, 2023 •
edited
Loading

File EIPS/eip-5725.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-review Waiting on editor to review label Aug 30, 2023
@DeFiFoFum
Copy link
Contributor Author

Closing as this PR was supposed to go into forked repo.

@DeFiFoFum DeFiFoFum closed this Aug 30, 2023
@DeFiFoFum DeFiFoFum deleted the final/eip-5725 branch September 5, 2023 15:53
@Woodpile37 Woodpile37 mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot will be requested when the pull request is marked ready for review eth-bot is a code owner

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-final This EIP is Final t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DeFiFoFum @eth-bot @Apegurus @JorgeAtPaladin @Elliott-Green