-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-6466: SSZ receipts root #6466
Conversation
All reviewers have approved. Auto merging... |
6adac2d
to
b41c648
Compare
The commit 8ca78c7 (as a parent of 14a01e1) contains errors. |
* Add EIP: Transition to SSZ * Avoid CL/EL abbrev * Cleanups from review * remove block header conversion from scope * remove security discussion from scope * Update discussion link for new title * Clarifying comment about why receipts don't have LC issue * Update description * Remove blob wrapper; Sync EIP-2718 nums; Helpers for non-tx; data-gas * Fix section header * Add `transaction_hashes_root`. * rm fixed container capacity discussion from this EIP * Convert to `BlobTransaction` for sighash/hash computation * Further cleanup * Align `SignedTransaction` field order with serialization * Write permissions for Vitalik * Update constants for `Receipt` * Update `MAX_LOGS_PER_RECEIPT` * Add rationale about `ReceiptLog` data. * Remove merkle proof length from rationale * rm `TxHashVersion`, rm EIP-155 type, rm extra tree * rm `tx_hash` from `Receipt` for concurrent receipt/tx backfill (Geth) * typo (ty @dapplion) * Split away withdrawals (#6465) * Split away receipts (#6466)
@eth-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case you aren't aware, you'll have to rebase this on top of master
to fix the missing file errors.
Otherwise, looking great!
* Add EIP: Transition to SSZ * Avoid CL/EL abbrev * Cleanups from review * remove block header conversion from scope * remove security discussion from scope * Update discussion link for new title * Clarifying comment about why receipts don't have LC issue * Update description * Remove blob wrapper; Sync EIP-2718 nums; Helpers for non-tx; data-gas * Fix section header * Add `transaction_hashes_root`. * rm fixed container capacity discussion from this EIP * Convert to `BlobTransaction` for sighash/hash computation * Further cleanup * Align `SignedTransaction` field order with serialization * Write permissions for Vitalik * Update constants for `Receipt` * Update `MAX_LOGS_PER_RECEIPT` * Add rationale about `ReceiptLog` data. * Remove merkle proof length from rationale * rm `TxHashVersion`, rm EIP-155 type, rm extra tree * rm `tx_hash` from `Receipt` for concurrent receipt/tx backfill (Geth) * typo (ty @dapplion) * Split away withdrawals (ethereum#6465) * Split away receipts (ethereum#6466)
* Add EIP: SSZ receipts root * rm transactions reference * Formatting * Fix link * Use title case for titles * SSZ abbrev
* Add EIP: SSZ receipts root * rm transactions reference * Formatting * Fix link * Use title case for titles * SSZ abbrev
* Add EIP: SSZ receipts root * rm transactions reference * Formatting * Fix link * Use title case for titles * SSZ abbrev
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: