Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-6466: SSZ receipts root #6466

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Conversation

etan-status
Copy link
Contributor

@etan-status etan-status commented Feb 8, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@etan-status etan-status requested a review from eth-bot as a code owner February 8, 2023 16:42
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-core labels Feb 8, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 8, 2023

All reviewers have approved. Auto merging...

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 8, 2023
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Feb 8, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 8, 2023
etan-status added a commit to etan-status/EIPs that referenced this pull request Feb 8, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 8, 2023
@Pandapip1 Pandapip1 changed the title Add EIP: SSZ receipts root Add EIP-6466: SSZ receipts root Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

The commit 8ca78c7 (as a parent of 14a01e1) contains errors.
Please inspect the Run Summary for details.

eth-bot pushed a commit that referenced this pull request Feb 8, 2023
* Add EIP: Transition to SSZ

* Avoid CL/EL abbrev

* Cleanups from review

* remove block header conversion from scope

* remove security discussion from scope

* Update discussion link for new title

* Clarifying comment about why receipts don't have LC issue

* Update description

* Remove blob wrapper; Sync EIP-2718 nums; Helpers for non-tx; data-gas

* Fix section header

* Add `transaction_hashes_root`.

* rm fixed container capacity discussion from this EIP

* Convert to `BlobTransaction` for sighash/hash computation

* Further cleanup

* Align `SignedTransaction` field order with serialization

* Write permissions for Vitalik

* Update constants for `Receipt`

* Update `MAX_LOGS_PER_RECEIPT`

* Add rationale about `ReceiptLog` data.

* Remove merkle proof length from rationale

* rm `TxHashVersion`, rm EIP-155 type, rm extra tree

* rm `tx_hash` from `Receipt` for concurrent receipt/tx backfill (Geth)

* typo (ty @dapplion)

* Split away withdrawals (#6465)

* Split away receipts (#6466)
@SamWilsn
Copy link
Contributor

SamWilsn commented Feb 8, 2023

@eth-bot rerun

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case you aren't aware, you'll have to rebase this on top of master to fix the missing file errors.

Otherwise, looking great!

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 9, 2023
@github-actions github-actions bot added the c-update Modifies an existing proposal label Feb 9, 2023
@etan-status etan-status requested a review from SamWilsn February 9, 2023 20:01
@eth-bot eth-bot enabled auto-merge (squash) February 15, 2023 07:08
@eth-bot eth-bot merged commit 6e0d8ef into ethereum:master Feb 15, 2023
@etan-status etan-status deleted the el-sszreceipts branch February 15, 2023 11:26
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
* Add EIP: Transition to SSZ

* Avoid CL/EL abbrev

* Cleanups from review

* remove block header conversion from scope

* remove security discussion from scope

* Update discussion link for new title

* Clarifying comment about why receipts don't have LC issue

* Update description

* Remove blob wrapper; Sync EIP-2718 nums; Helpers for non-tx; data-gas

* Fix section header

* Add `transaction_hashes_root`.

* rm fixed container capacity discussion from this EIP

* Convert to `BlobTransaction` for sighash/hash computation

* Further cleanup

* Align `SignedTransaction` field order with serialization

* Write permissions for Vitalik

* Update constants for `Receipt`

* Update `MAX_LOGS_PER_RECEIPT`

* Add rationale about `ReceiptLog` data.

* Remove merkle proof length from rationale

* rm `TxHashVersion`, rm EIP-155 type, rm extra tree

* rm `tx_hash` from `Receipt` for concurrent receipt/tx backfill (Geth)

* typo (ty @dapplion)

* Split away withdrawals (ethereum#6465)

* Split away receipts (ethereum#6466)
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
* Add EIP: SSZ receipts root

* rm transactions reference

* Formatting

* Fix link

* Use title case for titles

* SSZ abbrev
fulldecent pushed a commit to fulldecent/EIPs that referenced this pull request Mar 13, 2023
* Add EIP: SSZ receipts root

* rm transactions reference

* Formatting

* Fix link

* Use title case for titles

* SSZ abbrev
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Add EIP: SSZ receipts root

* rm transactions reference

* Formatting

* Fix link

* Use title case for titles

* SSZ abbrev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants