Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

fix: preserve unused variables #29

Merged
merged 1 commit into from
Sep 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transform/get-esbuild-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ export const getEsbuildOptions = (
*
* minifyIdentifiers is disabled because debuggers don't use the
* `names` property from the source map
*
* minifySyntax is disabled because it does some tree-shaking
* eg. unused try-catch error variable
*/
minifySyntax: true,
minifyWhitespace: true,
keepNames: true,

Expand Down
42 changes: 25 additions & 17 deletions tests/specs/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,22 @@ const base64Module = (code: string) => `data:text/javascript;base64,${Buffer.fro

const fixtures = {
ts: `
try {
const unusedVariable1 = 1;
} catch (unusedError) {
const unusedVariable2 = 2;
}
export default 'default value' as string;
export const named: string = 'named';
export const functionName: string = (function named() {}).name;
`,

esm: `
try {
const unusedVariable1 = 1;
} catch (unusedError) {
const unusedVariable2 = 2;
}
export default 'default value';
export const named = 'named';
export const functionName = (function named() {}).name;
Expand All @@ -26,11 +36,13 @@ export default testSuite(({ describe }) => {
const transformed = transformSync(
fixtures.esm,
'file.js',
{
format: 'cjs',
},
{ format: 'cjs' },
);

// For debuggers
expect(transformed.code).toMatch('unusedVariable1');
expect(transformed.code).toMatch('unusedVariable2');

const fsRequire = createFsRequire(Volume.fromJSON({
'/file.js': transformed.code,
}));
Expand All @@ -50,9 +62,7 @@ export default testSuite(({ describe }) => {
import('fs');
${fixtures.esm}`,
'file.js',
{
format: 'cjs',
},
{ format: 'cjs' },
),
).not.toThrow();
});
Expand All @@ -62,9 +72,7 @@ export default testSuite(({ describe }) => {
const transformed = transformSync(
fixtures.ts,
fileName,
{
format: 'esm',
},
{ format: 'esm' },
);

expect(transformed.map).not.toBe('');
Expand All @@ -73,7 +81,7 @@ export default testSuite(({ describe }) => {

expect(map.sources.length).toBe(1);
expect(map.sources[0]).toBe(fileName);
expect(map.names).toStrictEqual([]);
expect(map.names).toStrictEqual(['named']);
});
});

Expand All @@ -82,11 +90,13 @@ export default testSuite(({ describe }) => {
const transformed = await transform(
fixtures.ts,
'file.ts',
{
format: 'esm',
},
{ format: 'esm' },
);

// For debuggers
expect(transformed.code).toMatch('unusedVariable1');
expect(transformed.code).toMatch('unusedVariable2');

const imported = await import(base64Module(transformed.code));
expect({ ...imported }).toStrictEqual({
default: 'default value',
Expand All @@ -100,9 +110,7 @@ export default testSuite(({ describe }) => {
const transformed = await transform(
fixtures.ts,
fileName,
{
format: 'esm',
},
{ format: 'esm' },
);

expect(transformed.map).not.toBe('');
Expand All @@ -111,7 +119,7 @@ export default testSuite(({ describe }) => {

expect(map.sources.length).toBe(1);
expect(map.sources[0]).toBe(fileName);
expect(map.names).toStrictEqual([]);
expect(map.names).toStrictEqual(['named']);
});
});
});
Expand Down