Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

fix: preserve unused variables #29

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

privatenumber
Copy link
Member

@privatenumber privatenumber commented Sep 21, 2022

Problem

closes privatenumber/tsx#98

Changes

Disable minifySyntax to preserve unused variables

Other information

Unused variables are no longer deleted, but variable names may not be preserved since esbuild could rename them: evanw/esbuild#2076

Unless esbuild preserves variable names, the debugger will need to add support for Sourcemap names

@privatenumber privatenumber marked this pull request as ready for review September 21, 2022 13:22
@privatenumber privatenumber merged commit 98221a8 into develop Sep 21, 2022
@privatenumber privatenumber deleted the disable-minify-syntax branch September 21, 2022 13:27
@privatenumber
Copy link
Member Author

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing --keep-names flag results in useless sourcemaps
1 participant