Finalize v5.0: fix Zip and Append

[aslesarenko]

• Closes Fix Coll.zip #766
• Closes Fix Coll.append #765

[codecov]

Codecov Report

Merging #771 (19c04f7) into v5.0-todos (7baefef) will increase coverage by 0.04%.
The diff coverage is 95.65%.

@@              Coverage Diff               @@
##           v5.0-todos     #771      +/-   ##
==============================================
+ Coverage       71.68%   71.72%   +0.04%     
==============================================
  Files             248      248              
  Lines           18775    18790      +15     
  Branches          623      607      -16     
==============================================
+ Hits            13458    13478      +20     
+ Misses           5317     5312       -5     

Impacted Files	Coverage Δ
...mon/src/main/scala/sigmastate/VersionContext.scala	68.75% <75.00%> (+4.46%)	⬆️
common/src/main/scala/sigmastate/util.scala	100.00% <100.00%> (ø)
...ain/scala/special/collection/CollsOverArrays.scala	87.03% <100.00%> (+0.68%)	⬆️
.../src/main/scala/sigmastate/DataValueComparer.scala	93.85% <0.00%> (-0.56%)	⬇️
.../main/scala/sigmastate/utils/SigmaByteReader.scala	92.06% <0.00%> (ø)
.../org/ergoplatform/validation/ValidationRules.scala	92.53% <0.00%> (ø)
sigmastate/src/main/scala/sigmastate/types.scala	92.93% <0.00%> (+0.09%)	⬆️
core/src/main/scala/scalan/DefRewriting.scala	74.11% <0.00%> (+1.17%)	⬆️
.../src/main/scala/special/collection/ViewColls.scala	90.10% <0.00%> (+2.19%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7baefef...19c04f7. Read the comment docs.

[kushti]

LGTM, but please note:

1. for interpreter, version, isActivatedVersionJit sounds ok , and even more precise than isActivatedVersionGreaterV1
2. Please check the following commented out test in CollsTest

// TODO the following test fails because equality of Seq is not deep, and nested arrays are shallow compared
//    forAll(tokensGen, minSuccess) { c1 =>
//      println(s"c1=${c1.x.toArray.toSeq.map { case (id, v) => (id.toSeq, v) }}")
//      val tokens = c1.x
//      assert(tokens.toArray.toSeq == tokensArr.toSeq)
//    }

maybe it is not actual anymore, if actual, better to do GH issue, as commented out code , as well as TODO in the testing codebase can be forgotten for like forever

[aslesarenko]

• for interpreter, version, isActivatedVersionJit sounds ok , and even more precise than isActivatedVersionGreaterV1

• Please check the following commented out test in CollsTest

1. I would stick with isActivatedVersionGreaterV1 for consistency.
2. This is obsolete check, removed.

[kushti]

@aslesarenko named constants are used for improving readability, consistency is not needed there. For interpreter, isJitActivated says more than isActivatedVersionGreaterV1

[aslesarenko]

Ok, will change in the next PR