Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize v5.0 (part1) #761

Merged
merged 14 commits into from
Jan 28, 2022
Merged

Finalize v5.0 (part1) #761

merged 14 commits into from
Jan 28, 2022

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented Dec 22, 2021

  • implemented some // TODO optimize
  • more tests for TypeSerializer
  • negative test cases when lambda is not with single argument
  • more // TODO cover
  • fixed CollectionUtil.joinSeq method + tests
  • identified the problem with Coll.append (added regression tests for ET v0, v1)

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #761 (5abc74e) into v5.0-finalize (0fa0448) will increase coverage by 0.10%.
The diff coverage is 85.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           v5.0-finalize     #761      +/-   ##
=================================================
+ Coverage          71.53%   71.64%   +0.10%     
=================================================
  Files                246      246              
  Lines              18731    18724       -7     
  Branches             603      624      +21     
=================================================
+ Hits               13400    13414      +14     
+ Misses              5331     5310      -21     
Impacted Files Coverage Δ
core/src/main/scala/scalan/TypeDescs.scala 83.33% <ø> (ø)
...ain/scala/special/collection/CollsOverArrays.scala 86.48% <ø> (ø)
.../main/scala/special/sigma/SigmaDslOverArrays.scala 45.16% <ø> (ø)
.../main/scala/org/ergoplatform/ErgoLikeContext.scala 90.09% <ø> (ø)
...n/scala/org/ergoplatform/ErgoLikeInterpreter.scala 90.00% <ø> (ø)
.../src/main/scala/sigmastate/DataValueComparer.scala 94.41% <ø> (ø)
...state/src/main/scala/sigmastate/UnprovenTree.scala 100.00% <ø> (ø)
...ain/scala/sigmastate/eval/CostingDataContext.scala 78.62% <ø> (ø)
...rc/main/scala/sigmastate/eval/RuntimeCosting.scala 91.05% <ø> (ø)
...ala/sigmastate/interpreter/ErgoTreeEvaluator.scala 93.93% <ø> (+2.08%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa0448...5abc74e. Read the comment docs.

@aslesarenko aslesarenko mentioned this pull request Dec 22, 2021
21 tasks
@aslesarenko aslesarenko changed the base branch from v5.0-increase-script-version to v5.0-finalize-opt December 23, 2021 10:02
@aslesarenko aslesarenko deleted the branch v5.0-finalize December 25, 2021 08:17
@aslesarenko aslesarenko reopened this Dec 25, 2021
@aslesarenko aslesarenko changed the base branch from v5.0-finalize-opt to v5.0-finalize December 25, 2021 08:21
@aslesarenko aslesarenko requested a review from kushti December 25, 2021 08:23
@aslesarenko aslesarenko requested a review from kushti January 4, 2022 19:35
@aslesarenko aslesarenko requested a review from kushti January 26, 2022 17:10
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, LGTM, but please check PR description (outdated now)

@aslesarenko aslesarenko merged commit 5aa9945 into v5.0-finalize Jan 28, 2022
@aslesarenko aslesarenko deleted the v5.0-finalize-part1 branch January 28, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants