-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize v5.0 (part1) #761
Conversation
aslesarenko
commented
Dec 22, 2021
•
edited
Loading
edited
- implemented some // TODO optimize
- more tests for TypeSerializer
- negative test cases when lambda is not with single argument
- more // TODO cover
- fixed CollectionUtil.joinSeq method + tests
- identified the problem with Coll.append (added regression tests for ET v0, v1)
Codecov Report
@@ Coverage Diff @@
## v5.0-finalize #761 +/- ##
=================================================
+ Coverage 71.53% 71.64% +0.10%
=================================================
Files 246 246
Lines 18731 18724 -7
Branches 603 624 +21
=================================================
+ Hits 13400 13414 +14
+ Misses 5331 5310 -21
Continue to review full report at Codecov.
|
sigmastate/src/main/scala/sigmastate/serialization/ValueSerializer.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, LGTM, but please check PR description (outdated now)