-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pie chart plot type added to TablePlotter #330
Conversation
Congrats with making your first PR @robpoll 🎉 One comment: Think at least we should add the possibility to use a column as labels/names, as that would make it a lot easier to analyze results, see e.g.: https://plotly.com/python/pie-charts/ |
Thanks man! You've helped me a lot! @asnyv |
Might be that you have to call it "labels" as it is defined here @robpoll https://plotly.com/python/reference/pie/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Asgeir Nyvoll <47146384+asnyv@users.noreply.github.com>
Could you add to the CHANGELOG.md as well @robpoll ? |
Yes, is it now alright @asnyv ? |
Looks good to me at least 👍 any final comments @anders-kiaer or @HansKallekleiv ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
CHANGELOG.md
, and added it if should be communicated there.