Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pie chart option to TablePlotter #297

Closed
asnyv opened this issue Sep 16, 2020 · 9 comments · Fixed by #330
Closed

Add pie chart option to TablePlotter #297

asnyv opened this issue Sep 16, 2020 · 9 comments · Fixed by #330
Assignees
Labels
enhancement 🚀 New feature or request good first issue Good for newcomers

Comments

@asnyv
Copy link
Collaborator

asnyv commented Sep 16, 2020

Is your feature request related to a problem? Please describe.
Add pie chart option to TablePlotter

Describe the solution you'd like
Possibility to plot pie charts based on a table/dataframe (already available as pie in Plotly)

Describe alternatives you've considered
Separate plugin for pie charts, but think it should be quite easy to expand the TablePlotter with this option

@robpoll
Copy link
Contributor

robpoll commented Sep 30, 2020

I'd like to take this issue.

@robpoll
Copy link
Contributor

robpoll commented Oct 1, 2020

When I open the webviz webapp and I click on Plot a Table I should have a pie chart plot type here.
That's what I have to implement here, right @asnyv ?

@asnyv
Copy link
Collaborator Author

asnyv commented Oct 1, 2020

Yep @robpoll 😊 you probably need some logic on what sort of selectors that are relevant for a pie chart (similar to how the selectors change based on the other plot types).

@robpoll
Copy link
Contributor

robpoll commented Oct 19, 2020

I added the option of a pie chart in tableplotter. Right now, it's pretty rough. Only one choice for what data to visualise based on columns which consists only numerical data.

How can I know when is the issue complete? @asnyv

@asnyv
Copy link
Collaborator Author

asnyv commented Oct 19, 2020

could you create a pull request for it @robpoll? Then we can see your code, and test it if it's ready for that. 😄

@robpoll
Copy link
Contributor

robpoll commented Oct 19, 2020

I'd like to add more details to it, like I said, it's pretty rough atm :D
Anyways, how can I create a PR? It's my first contribution on github, and I'm pretty much lost. @asnyv

@robpoll
Copy link
Contributor

robpoll commented Oct 19, 2020

After the latest pull my implementation doesn't work. Changing the _table_plotter.py under generic plugins doesn't seem to affect anything. @asnyv

@asnyv
Copy link
Collaborator Author

asnyv commented Oct 19, 2020

hmm, you might have to rerun pip install -e . when you are in the main folder then @robpoll (same folder as setup.py is located in) see the installation guide.

When it comes to creating a PR: It seems like you haven't forked this repository yet? In that case read this small guide on what a fork is, how to clone it, stage/commit changes and making a pull request. And if you have any questions after that, let me know :)

@robpoll
Copy link
Contributor

robpoll commented Oct 19, 2020

Running pip install -e . fixed the issue. I have created a PR but I haven't created tests yet and such. @asnyv

@anders-kiaer anders-kiaer moved this to Done 🏁 in Webviz Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants