Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show zoom level in centre or terminal when changing. #772

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Aug 10, 2024

#626 Based on igordsm/zoom-overlay incorporating @danirabbit 's suggestions.

Granite.OverlayBar is used for simplicity and consistency with Files.

@jeremypw jeremypw requested a review from danirabbit August 10, 2024 15:01
@jeremypw
Copy link
Collaborator Author

Should ZoomOverlay widget be merged into MainWindow now thereby losing a Gtk.Bin?

@danirabbit
Copy link
Member

@jeremypw sorry thought I responded to this. What do you think about using Granite.Overlaybar for this? #773

@jeremypw
Copy link
Collaborator Author

@danirabbit Looks like it would be appropriate - thanks. Is Granite-7 available on OS7.1 though?

@danirabbit
Copy link
Member

@jeremypw it is! But granite-7 is just for gtk4 apps. This uses overlay bar from granite 6

@jeremypw
Copy link
Collaborator Author

OK, sorry for the confusion. I think we would still have to use markup to get 24pt text though? Are you OK with that size? I feel it needs to be more prominent than default text size if displayed over text.

@jeremypw
Copy link
Collaborator Author

@danirabbit I changed it to Granite.OverlayBar but then noticed you had already pushed a new PR! The main difference is that the size and position of the overlaid widget is not controllable so the vision of the OP cannot be realized. However using the native Granite widget has the advantage of being consistent with the Files appearance when file items are selected. Also fewer code lines.

@jeremypw jeremypw force-pushed the jeremypw/zoom-overlay branch from ad75da7 to 8fabe6c Compare August 18, 2024 10:21
danirabbit and others added 2 commits August 18, 2024 11:21
* Use overlaybar style, cleanup

* ZoomOverlay: use overlaybar

* Remove extra styles
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

@danirabbit danirabbit merged commit 5d4eae7 into master Aug 20, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/zoom-overlay branch August 20, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants