-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show zoom level in centre or terminal when changing. #772
Conversation
# Conflicts fixed in: # meson.build # src/MainWindow.vala
Should ZoomOverlay widget be merged into MainWindow now thereby losing a Gtk.Bin? |
@danirabbit Looks like it would be appropriate - thanks. Is Granite-7 available on OS7.1 though? |
@jeremypw it is! But granite-7 is just for gtk4 apps. This uses overlay bar from granite 6 |
OK, sorry for the confusion. I think we would still have to use markup to get 24pt text though? Are you OK with that size? I feel it needs to be more prominent than default text size if displayed over text. |
@danirabbit I changed it to Granite.OverlayBar but then noticed you had already pushed a new PR! The main difference is that the size and position of the overlaid widget is not controllable so the vision of the OP cannot be realized. However using the native Granite widget has the advantage of being consistent with the Files appearance when file items are selected. Also fewer code lines. |
ad75da7
to
8fabe6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean!
#626 Based on igordsm/zoom-overlay incorporating @danirabbit 's suggestions.
Granite.OverlayBar is used for simplicity and consistency with Files.