Show zoom level in the center of terminal #626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts fixed in: # meson.build # src/MainWindow.vala
|
@danirabbit Is this idea OK from design viewpoint? If so, you may wish to adjust the CSS. |
danirabbit
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Interesting enough. I don't have any real objections to the idea.
I think there's some issues from a code perspective, like Gtk.Overlay and Revealer are both sealed in GTK4 so you can't subclass them and adding a style provider to a widget is deprecated.
It might actually be better to just have the zoom widget class set css name to "tooltip" to recycle tooltip styles instead of adding a new style here
|
@danirabbit Thanks for the input. @igordsm Are you interested in taking this up again? Otherwise I will try to implement @danirabbit 's suggestions. |
|
Closing since #772 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion about design in the issue. Will close #442