Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Missing Call Icons when threads are enabled #5847

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Fixes Missing Call Icons when threads are enabled #5847

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6a03cd
Fixes missing call icons
ericdecanini Apr 26, 2022
e4cd31d
Adds changelog file
ericdecanini Apr 26, 2022
6548c3c
Replaces call title with action_voice_call
ericdecanini Apr 26, 2022
9c95168
Moves tools ignore AlwaysShowAction to root of menu_timeline
ericdecanini Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5847.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes missing call icons when threads are enabled
12 changes: 8 additions & 4 deletions vector/src/main/res/menu/menu_timeline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,32 +19,36 @@
android:title="@string/action_invite"
app:showAsAction="never" />

<!-- We always want to show this item as an icon -->
<item
android:id="@+id/video_call"
android:icon="@drawable/ic_video"
android:title="@string/action_video_call"
android:visible="false"
app:iconTint="?colorPrimary"
app:showAsAction="ifRoom"
app:showAsAction="always"
tools:visible="true" />

<!-- We always want to show this item as an icon -->
<item
android:id="@+id/voice_call"
android:icon="@drawable/ic_phone"
android:title="@string/call"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe take the opportunity to use action_voice_call instead of call for parity. action_voice_call has the value "Voice call". This string can still be visible by the user when long pressing on the menu item.

android:visible="false"
app:iconTint="?colorPrimary"
app:showAsAction="ifRoom"
app:showAsAction="always"
tools:visible="true" />

<!-- We always want to show this item as an icon -->
<item
android:id="@+id/menu_timeline_thread_list"
android:title="@string/action_view_threads"
android:visible="false"
app:actionLayout="@layout/view_thread_notification_badge"
app:iconTint="?colorPrimary"
app:showAsAction="always"
tools:visible="true" />
tools:visible="true"
tools:ignore="AlwaysShowAction" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely adding this attribute in this item XML tag also has an effect on the warnings of the other item tags 🤔 .
Anyway for clarity, you should probably move this tools:ignore to the root XML tag menu.


<item
android:id="@+id/join_conference"
Expand Down Expand Up @@ -86,4 +90,4 @@
android:title="@string/action_share"
app:iconTint="?vctr_content_secondary"
app:showAsAction="withText" />
</menu>
</menu>