Fixes Missing Call Icons when threads are enabled #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdecanini
changed the title
bmarty
requested changes
Apr 26, 2022
| <item | ||
| android:id="@+id/menu_timeline_thread_list" | ||
| android:title="@string/action_view_threads" | ||
| android:visible="false" | ||
| app:actionLayout="@layout/view_thread_notification_badge" | ||
| app:iconTint="?colorPrimary" | ||
| app:showAsAction="always" | ||
| tools:visible="true" /> | ||
| tools:visible="true" | ||
| tools:ignore="AlwaysShowAction" /> |
There was a problem hiding this comment.
Strangely adding this attribute in this item XML tag also has an effect on the warnings of the other item tags 🤔 .
Anyway for clarity, you should probably move this tools:ignore to the root XML tag menu.
| tools:visible="true" /> | ||
|
|
||
| <!-- We always want to show this item as an icon --> | ||
| <item | ||
| android:id="@+id/voice_call" | ||
| android:icon="@drawable/ic_phone" | ||
| android:title="@string/call" |
There was a problem hiding this comment.
Maybe take the opportunity to use action_voice_call instead of call for parity. action_voice_call has the value "Voice call". This string can still be visible by the user when long pressing on the menu item.
bmarty
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes missing call menu items due to
ifRoombeing used instead ofalwaysMotivation and context
Closes #5840
I also added lint suprression and comments explaining why we keep these icons as
app:showAsAction="always"as it can be very easy to overlook with the IDE warningsScreenshots / GIFs
Tests
Tested devices
Checklist