Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text to spinner when click on space member (dm) #5685

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Apr 4, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • [] Other :

Content

add text to spinner when selecting person to start dm via space people list

Motivation and context

closes #4305

Screenshots / GIFs

Screenshot 2022-04-04 at 9 49 09

Tests

  • select space
  • select "people" tab
  • press fab
  • select a person (there shouldn't be already created dm with this person)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@fedrunov fedrunov requested review from a team and ahmed-radhouane and removed request for a team April 4, 2022 08:05
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Unit Test Results

114 files  +  4  114 suites  +4   1m 15s ⏱️ -20s
201 tests +  6  201 ✔️ +  6  0 💤 ±0  0 ±0 
674 runs  +24  674 ✔️ +24  0 💤 ±0  0 ±0 

Results for commit 8ae130c. ± Comparison against base commit 3aac59a.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a small file for the changelog please?

@fedrunov fedrunov requested a review from bmarty April 12, 2022 12:44
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bmarty bmarty merged commit 948566c into develop Apr 15, 2022
@bmarty bmarty deleted the feature/nfe/space_member_spinner_text branch April 15, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner has no text next to it
2 participants