Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner has no text next to it #4305

Closed
kittykat opened this issue Oct 21, 2021 · 2 comments · Fixed by #5685
Closed

Spinner has no text next to it #4305

kittykat opened this issue Oct 21, 2021 · 2 comments · Fixed by #5685
Assignees
@niquewoodhouse @fedrunov
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 21, 2021 •
edited
Loading

Steps to reproduce

  1. Browse users in a space
  2. Click on user
  3. See spinner in a wide dialog without any text

Intended result and actual result

What did you expect?

Some text telling me what is going on

What happened instead?

Screenshot_20211020-154708.png

Application version and app store

Element 1.3.4 (RC)

Will you send logs?

No
@kittykat kittykat added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 21, 2021
@ganfra ganfra added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 22, 2021
@fedrunov
Copy link
Contributor

@niquewoodhouse which text should we show here? Just some generic "loading..." (we have already this copy) or something more specific to an action?

@niquewoodhouse
Copy link

@fedrunov if we generally use "loading" for this, using the same copy makes the most sense. Thanks for raising this

@fedrunov fedrunov mentioned this issue Apr 4, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niquewoodhouse niquewoodhouse

@fedrunov fedrunov

Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add text to spinner when click on space member (dm) element-hq/element-android
4 participants
@kittykat @niquewoodhouse @ganfra @fedrunov