Notify channel on sanity test result #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
ouchadam
reviewed
Feb 23, 2022
| @@ -78,3 +78,17 @@ jobs: | |||
| path: | | |||
| emulator.log | |||
| failure_screenshots/ | |||
|
|
|||
|
|
|||
| notify: | |||
There was a problem hiding this comment.
what happens if the matrix secret is empty? thinking of what will happen for forks~ (if they have actions enabled)
There was a problem hiding this comment.
The code handles empty string as a requirement not to send the request; the information will be debugged in the task but not sent anywhere.
There was a problem hiding this comment.
I haven't tested this explicitly, though I have tested by setting the secrets to invalid values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Github workflow has been enhanced with a notification to the correct matrix channel.
Configuration is via secrets for channel, matrix token, but the message body is templatable in the workflow file if required.
Motivation and context
Fixes #5314
Screenshots / GIFs
Tests
michaelk/gha_experiment branch has been running this code on push and the notification worked.
Tested devices
N/A
Checklist