fix(tabs): replace tab character by space characters #8629
Conversation
With default configuration, just opening and saving the file is updating this file automatically Change-Id: Iac8580fc5f723f78adf5ad8aa3818d835ec3727e Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added
plug-in system
There was a problem hiding this comment.
The changes look good to me 👍
@benoitf what do you think of enabling the following eslint rule: https://eslint.org/docs/rules/indent
We can enforce that spaces are used always, and display warnings or errors when tabs are used.
|
@vince-fugnitto yes would be nice because when we just open/save files, they're producing changes |
| @@ -1582,168 +1582,168 @@ declare module '@theia/plugin' { | |||
| waitUntil(thenable: PromiseLike<any>): void; | |||
There was a problem hiding this comment.
I just wanted to mention that this file is never checked by eslint due to the following ignorePatterns:
theia/configs/base.eslintrc.json
Lines 21 to 24 in 40b3800
There was a problem hiding this comment.
maybe this one should not be excluded as it's maintained by us manually
There was a problem hiding this comment.
maybe this one should not be excluded as it's maintained by us manually
I think so, we should update the ignorePatterns to only check *d.ts files located under lib folders correct, or just lib altogether?
What it does
just replace tab characters by space
How to test
you may reproduce this fix just by opening and saving the file.
About test, hard to say how to test as it's like a no-op but plug-ins should still work as usual
And in github diff view, you can see it's only related to spaces/indent
Review checklist
Reminder for reviewers