Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: update ignorePatterns #8632

Closed
vince-fugnitto opened this issue Oct 14, 2020 · 0 comments · Fixed by #8630
Closed

lint: update ignorePatterns #8632

vince-fugnitto opened this issue Oct 14, 2020 · 0 comments · Fixed by #8630
Assignees
Labels
linting issues related to linting quality issues related to code and application quality

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The ignorePatterns for eslint are incorrect and mean that our own theia.d.ts and theia-proposed.d.ts files for instance are never linted causing issues, and unnecessary changes during pull-request which then need to be fixed such as #8629.

"ignorePatterns": [
"node_modules",
"*.d.ts"
]

We should update the ignorePatterns to instead exclude all content under lib folders.

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality linting issues related to linting labels Oct 14, 2020
@vince-fugnitto vince-fugnitto self-assigned this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting issues related to linting quality issues related to code and application quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant