debug: remove plugin import #10718
Merged
debug: remove plugin import #10718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit refactors `@theia/debug` to not import from the plugin-system, and instead moves the plugin specific code to the appropriate location. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
debug
alvsan09
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
I have tested it using the 'vscode-mock-debug' extension using run modes 'external', 'namedPipeServer' and 'server' it works as expected.
The 'inline' mode does not work i.e. registerInlineValuesProvider not supported, however this is unrelated to this change. 👍
The code looks good to me as well !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10714
The pull-request refactors code from
@theia/debugwhich previously incorrectly imported directly from@theia/plugin.The commit moves the plugin specific code directly to the plugin system.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com