Add DebugAdapterNamedPipeServer and DebugAdapterInlineImplementation

[tsmaeder]

What it does

Adds new debug adapter descriptor types to the plugin API
Fixes #10006

How to test

Check out the mock debug extension (https://github.com/Microsoft/vscode-mock-debug) and build it (yarn compile & yarn package) in various debug adapter mode (see extension.ts#21). Also, you need to remove some stuff that we don't support yet from activateMockDebug.ts, here's the changed file:

activateMockDebug.ts.txt

The extension allows to add a launch configuration that will step through any *.md file. You just have to point the config at a concrete file instead of using the "select file" command.

Note that there is a bug in session management curently: #10164. The bug is present independent of the introduction of new debug adapter types in this PR and therefore should be handled separately.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

The changes look quite good to me, I was able to successfully debug with all four different debug flags.

I had a few issues testing any flags that relied on the external debugAdapter.js process, since that isn't built by the webpack config. I'll include all compiled vsix (including the debugAdapter.js) in a single zip here for other reviewers. Be aware that after installing a different version of the extension the backend needs to be restarted, as new debug adapters will not override old ones:

mock-debug-0.46.7.zip

[alvsan09]

I have tested it using the vscode-mock-debug extension and it works fine 👍

I have just noticed a possible copy/paste issue as per inline comment.

One comment:
I ran into some additional adjustments to be able to compile and re-run the `vscode-mock-debug' extension, I had to use this extension in the PR mentioned below and created a branch to make it easier for reviewers. may be something to consider.
Hopefully we can have a fully working branch after few more fixes in the area.
#10134

[tsmaeder]

@alvsan09 @msujew I've addressed the comments and rebased the branch. Now I just need an approval :-)

[msujew]

The changes look good to me! I am successfully able to run the different configs of the mock extension using Theia now.

[alvsan09]

It looks good to me !
Thanks Thomas! 👍

[thegecko]

This file debug/lib/node/debug-model should have been kept in the common folder. The move has blocked browser-based adapters from working.

cc @tsmaeder

[tsmaeder]

@thegecko you're right, of course, it just looked like an implementation detail of the back end. Can you open an issue with what you need in the common folder so we can track it?

[thegecko]

@thegecko you're right, of course, it just looked like an implementation detail of the back end. Can you open an issue with what you need in the common folder so we can track it?

I think this work and your efforts in #10333 allows me to upstream in-browser debug adapter support more easily, so I could make these changes when doing that.

[tsmaeder]

@thegecko currently, the default implementation of the DebugService lives in the back end. Moving that to the front end would more easily allow for contributors to implement debug adapter connections in the front or back end. It's a bit bass ackwards, right now, if you ask me.