Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small bugs for dashboard #11569

Merged
merged 4 commits into from
Oct 11, 2018
Merged

Fix small bugs for dashboard #11569

merged 4 commits into from
Oct 11, 2018

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 9, 2018

What does this PR do?

Fix empty 'Edit the machine' form error. Fix the regular expression for a workspace name.

What issues does this PR fix or reference?

#10659
#10732

@olexii4 olexii4 changed the title Che 10732 Fix small bugs for dashboard Oct 9, 2018
@olexii4
Copy link
Contributor Author

olexii4 commented Oct 9, 2018

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 9, 2018
@riuvshin
Copy link
Contributor

riuvshin commented Oct 9, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
Copy link
Contributor Author

olexii4 commented Oct 10, 2018

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
CHE-10659 Fix the regular expression for a workspace name
fcafb61 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
CHE-10732 Fix empty 'Edit the machine' form error
34fddd2 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Fix import git project service
ca3467e 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Fix create factory flow
07880c3 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Copy link
Contributor Author

olexii4 commented Oct 10, 2018

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4 olexii4 mentioned this pull request Oct 11, 2018
Closed
@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/964/) doesn't show any regression against this Pull Request.

@olexii4 olexii4 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 11, 2018
@olexii4 olexii4 added this to the 6.13.0 milestone Oct 11, 2018
@olexii4 olexii4 merged commit eab323d into master Oct 11, 2018
@olexii4 olexii4 deleted the CHE-10732 branch October 11, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova ashumilova approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@olexii4 @riuvshin @SkorikSergey @benoitf @ashumilova @akurinnoy