Fix table cell renderer highlighting of search term matches #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
force-pushed
the
regex
branch
2 times, most recently
from
fdca465 to
829938c
Compare
Use global regex to get all matching strings not only the first match. Handle different behavior of String.split() when regex contains capturing groups. Fixes eclipse-cdt-cloud#1160 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
|
There are two dependencies not passing the license check - same when I run the license check on master locally. They both already have a IP ticket: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/19199 Since the PR here is not introducing them, I would say feel free to ignore those 2 |
bhufmann
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Use global regex to get all matching strings not only the first match.
Handle different behavior of String.split() when regex contains capturing groups.
Fixes #1160
How to test
Try a regex with multiple not-equal matches, e.g. a|b.
Try a regex with captured matching groups, e.g. (a|b).
Try a regex with captured and uncaptured matches, e.g. a|(b)
Follow-ups
N/A
Review checklist