Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events table search filter causes displayed string to change when using groups #1160

Closed
bhufmann opened this issue Dec 4, 2024 · 0 comments · Fixed by #1167
Closed

Events table search filter causes displayed string to change when using groups #1160

bhufmann opened this issue Dec 4, 2024 · 0 comments · Fixed by #1167
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Dec 4, 2024

Bug Description:

Events table search filter causes displayed string to change when using groups.

Steps to Reproduce:

  1. Open a trace
  2. Open Events Table
  3. Enter a filter string with group and or operator in one column

vscode-events-table-search-bug

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: 1.52.0
@bhufmann bhufmann added the bug Something isn't working label Dec 4, 2024
PatrickTasse added a commit to PatrickTasse/theia-trace-extension that referenced this issue Jan 28, 2025
@PatrickTasse
Fix table cell renderer highlighting of search term matches
ece2ff6 
Use global regex to get all matching groups not only the first match.

Handle different behavior of String.split() when regex contains groups.

Fixes eclipse-cdt-cloud#1160

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
@PatrickTasse PatrickTasse mentioned this issue Jan 28, 2025
Merged
1 task
PatrickTasse added a commit to PatrickTasse/theia-trace-extension that referenced this issue Jan 28, 2025
@PatrickTasse
Fix table cell renderer highlighting of search term matches
fdca465 
Use global regex to get all matching strings not only the first match.

Handle different behavior of String.split() when regex contains
capturing groups.

Fixes eclipse-cdt-cloud#1160

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse added a commit to PatrickTasse/theia-trace-extension that referenced this issue Jan 28, 2025
@PatrickTasse
Fix table cell renderer highlighting of search term matches
829938c 
Use global regex to get all matching strings not only the first match.

Handle different behavior of String.split() when regex contains
capturing groups.

Fixes eclipse-cdt-cloud#1160

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse added a commit to PatrickTasse/theia-trace-extension that referenced this issue Jan 28, 2025
@PatrickTasse
Fix table cell renderer highlighting of search term matches
6dc6b4b 
Use global regex to get all matching strings not only the first match.

Handle different behavior of String.split() when regex contains
capturing groups.

Fixes eclipse-cdt-cloud#1160

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse added a commit that referenced this issue Jan 28, 2025
@PatrickTasse
Fix table cell renderer highlighting of search term matches
b39c595 
Use global regex to get all matching strings not only the first match.

Handle different behavior of String.split() when regex contains
capturing groups.

Fixes #1160

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix table cell renderer highlighting of search term matches PatrickTasse/theia-trace-extension
1 participant
@bhufmann