Include ag-grid in build (see eXist-db/eXide#376) #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory `resources/css/ag-grid-community` is created on `npm run build`, and its contents are gitignored. On `npm run build clean`, the directory and its contents are deleted.
|
@amclark42 Many thanks! This PR is included in eXide 3.3.0, published to the public-repo and to GitHub Releases. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build process copies CSS within
node_modules/@ag-grid-communityinto a git-ignored directoryresources/css/ag-grid-community. The eXide HTML template now references local copies of the ag-grid CSS, thus bypassing CORS issues and allowing the Open / Manage dialogs to work offline.Tested locally using eXist v5.3.1 on a Mac.