-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit dependency management #216
Conversation
Lovely! I haven't read through the PR but I hope it contains the Small thing, maybe use the term |
Yeah, I'm only just starting work now that the prereq backlog is sorted, hence draft status. This won't take long to implement and should be an easy one-man job. I'm currently focusing on public API work (docs, types, messages) before doing the simple private work. |
nice! I might make a small PR which fixes all of the stuff on the docs unless you’ve already got that. |
I'll be fine - there's some nuance required for the tutorials. |
Also didn’t realise you could link prs and issues so that’s my bad! |
oh okay! I’ll find some other issues or things to work on in the meantime |
The most recent commit poses an interesting question. For the for* objects, will |
Yes. Having the |
Probably done for the day at this point. I haven't yet tested any of this code, but this should roughly be along the right lines. Will need to update tests and benchmarks too. |
Nice! If you need help lmk haha but it should be easy enough as u said. I’m gonna most likely work on some others today during class |
One small thing you probably forgot is to change Attributes to use |
This should be ready now. I know there's a few places where I could perhaps do more caching work, but we can do that in the future - it's more important to merge a working version than an optimal one, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change I found here, if it's intentional please let me know!
Implements #111, #168, and #35. First steps towards #205.
:get()
will now error when called.Fusion.peek
will retrieve the value of any state object without adding dependencies, or pass through constants.peek
in dependency management code to generateuse
callbacks for use by the API consumer. These should also pass through constants.