Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StateObject:get() from the public API #168

Closed
dphfox opened this issue Jun 4, 2022 · 3 comments · Fixed by #216
Closed

Remove StateObject:get() from the public API #168

dphfox opened this issue Jun 4, 2022 · 3 comments · Fixed by #216
Assignees
Labels
enhancement New feature or request ready to work on Enhancements/changes ready to be made

Comments

@dphfox
Copy link
Owner

dphfox commented Jun 4, 2022

Alternate idea to #159 - since we're introducing unwrap() in v0.3, users will already have a great consistent way to get the value of any state object. There's no case where using unwrap() would be disadvantageous over using :get(), and generally using :get() locks your code into only using state objects, so the case for keeping this method public is rather vague and weak.

We'll still need a method like this to exist, of course - unwrap() needs someplace to source its values, after all - but perhaps that is better left as a lower level implementation detail that only the authors of state objects need to worry about, not general users of Fusion.

@dphfox dphfox added enhancement New feature or request not ready - evaluating Currently gauging feedback labels Jun 4, 2022
@dphfox
Copy link
Owner Author

dphfox commented Jun 4, 2022

Related to #111

@dphfox dphfox added ready to work on Enhancements/changes ready to be made and removed not ready - evaluating Currently gauging feedback labels Aug 30, 2022
@dphfox dphfox moved this to To Do in Fusion 0.3 Feb 1, 2023
@dphfox dphfox self-assigned this Feb 1, 2023
@krypt102
Copy link
Contributor

krypt102 commented Feb 1, 2023

Is there going to be any difference between this and peek()? Provided that we're adding that.

@dphfox dphfox moved this from To Do to In Progress in Fusion 0.3 Feb 5, 2023
@dphfox dphfox linked a pull request Feb 5, 2023 that will close this issue
@dphfox
Copy link
Owner Author

dphfox commented Feb 5, 2023

Is there going to be any difference between this and peek()? Provided that we're adding that.

See #217 for an explanation of the differences.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Fusion 0.3 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to work on Enhancements/changes ready to be made
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants