Use theme to create DocumentGridPage borders #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
ryalanms
approved these changes
Mar 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what the title says. The border/shadow can now be customized by creating a style with the key
{ComponentResourceKey TypeInTargetAssembly={x:Type FrameworkElement}, ResourceId=DocumentGridPageContainerWithBorder}at whatever scope you desire. The default value for this style is a copy of the current, manually constructed border. Here is a zipped demo project; note that you'll have to change the WpfRepoRoot variable inDocumentViewerTest.csprojbefore building.I also took the opportunity to rewrite
ThemeGenerator.nativeproj. It is now stripped of all MS-internal-isms and can be run with MSBuild directly to regenerate the XAML files in the theme projects.Fixes #1518.