Add latest build table to VMR README #47136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/SourceBuild/content/docs/package-table.md:8
- The table header only defines two columns, but this row contains four cells. Please update the row to match the intended column format.
| **Windows arm** | **N/A** | **N/A** | **N/A** |
ViktorHofer
force-pushed
the
AddBuildTableToVMR
branch
from
b4151ae to
2e0ec35
Compare
ViktorHofer
force-pushed
the
AddBuildTableToVMR
branch
from
6d9c601 to
b2b79d4
Compare
akoeplinger
approved these changes
Feb 26, 2025
| -------------------------------------------------------------------------------------- | ||
| | Platform | main<br>(10.0.x Runtime) | | ||
| | :--------- | :----------: | | ||
| | **Windows x64** | [![][win-x64-badge-main]][win-x64-version-main]<br>[Installer][win-x64-installer-main] - [Checksum][win-x64-installer-checksum-main]<br>[zip][win-x64-zip-main] - [Checksum][win-x64-zip-checksum-main] | |
There was a problem hiding this comment.
Version badges appear truncated -
There was a problem hiding this comment.
This gets fixed in this PR but requires a new official build. See the svg change in this PR.
|
@MichaelSimons & @akoeplinger thanks for the feedback. Note that this is a 1:1 copy from sdk. Would you mind if I react to it in a follow-up PR? I want to show this in today's platform talk, including a shoutout for dogfooding the bits. I'm also OK with addressing the feedback and then force-merging after the current CI run is green. |
|
sure, I'm fine with that |
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Michael Simons <msimons@microsoft.com>
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4717
Let's iterate on this post-merge (I want to have this ready for today's platform talk)