Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][ws] fix ConnectAsync_CancellationRequestedInflightConnect_ThrowsOperationCanceledException #97868

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

pavelsavara
Copy link
Member

Fixes #97092

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 2, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 2, 2024
@pavelsavara pavelsavara requested a review from maraf February 2, 2024 12:40
@pavelsavara pavelsavara self-assigned this Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #97092

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

pavelsavara and others added 2 commits February 2, 2024 14:34
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@pavelsavara
Copy link
Member Author

I'm really confused how this could happen.

Log

[15:05:50] info: [STRT] System.Net.WebSockets.Client.Tests.HttpClientConnectTest.ConnectAsync_CancellationRequestedBeforeConnect_ThrowsOperationCanceledException
[15:05:50] fail: [out of order message from the browser]: http://127.0.0.1:42619/_framework/dotnet.runtime.js 2 WebSocket connection to 'ws://38c12b6832644ebbbcc2f28974617f84/' failed: Error in connection establishment: net::ERR_NAME_NOT_RESOLVED
[15:05:50] warn: [0x000dc23c 15:05:50.656] MONO_WASM: WebSocket error
[15:05:50] info: [STRT] System.Net.WebSockets.Client.Tests.HttpClientConnectTest.ConnectAsync_PassNoSubProtocol_ServerRequires_ThrowsWebSocketException(server: ws://127.0.0.1:42619/WebSocket/EchoWebSocket.ashx)
[15:05:50] warn: [0x000dc23c 15:05:50.667] MONO_WASM: WebSocket error
[15:05:50] fail: [0x000dc23c 15:05:50.668] MONO_WASM: Unhandled error: {}
[15:05:50] fail: [0x000dc23c 15:05:50.669] MONO_WASM: {"status":1,"silent":true}
[15:05:50] fail: [out of order message from the browser]: http://127.0.0.1:42619/_framework/dotnet.runtime.js 2 WebSocket connection to 'ws://127.0.0.1:42619/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Response must not include 'Sec-WebSocket-Protocol' header if not present in request: CustomProtocol
[15:05:50] info: WASM EXIT 1

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit 9e48225 into dotnet:main Feb 5, 2024
130 of 139 checks passed
@pavelsavara pavelsavara deleted the browser_fix_ws_cancel branch February 5, 2024 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
3 participants