Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Jiterp Failed to patch opcode #97925

Closed
pavelsavara opened this issue Feb 3, 2024 · 3 comments
Closed

[browser][mt] Jiterp Failed to patch opcode #97925

pavelsavara opened this issue Feb 3, 2024 · 3 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono os-browser Browser variant of arch-wasm
Milestone

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Feb 3, 2024

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Failed to patch opcode.*into a monitor point",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317

Log

[20:03:05] info: Failed to patch opcode at 4cc6190 into a monitor point

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317
Error message validated: Failed to patch opcode.*into a monitor point
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 2/3/2024 5:36:41 PM UTC

Report

Build Definition Test Pull Request
551317 dotnet/runtime WasmTestOnBrowser-System.Threading.Tests.WorkItemExecution #97868

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 1
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Codegen-Interpreter-mono Known Build Error Use this to report build issues in the .NET Helix tab os-browser Browser variant of arch-wasm labels Feb 3, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 3, 2024
@ghost
Copy link

ghost commented Feb 3, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Failed to patch opcode.*into a monitor point",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317

Log

[20:03:05] info: Failed to patch opcode at 4cc6190 into a monitor point
Author: pavelsavara
Assignees: kg
Labels:

arch-wasm, blocking-clean-ci, area-Codegen-Interpreter-mono, Known Build Error, os-browser

Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

pavelsavara commented Feb 3, 2024

@kg as discussed please

  • update the log message to contain value of the new opcode and the value of existing opcode after failed cmpxchg
    • so that we learn why it failed, why the racing opcodes are not the same value in the first place
    • if they are same, we should not produce the warning, because that's ok
  • update the comment about threading doesn't work
  • consider renaming "monitor point"

@pavelsavara pavelsavara removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 3, 2024
@pavelsavara pavelsavara removed the Known Build Error Use this to report build issues in the .NET Helix tab label Feb 16, 2024
@lewing
Copy link
Member

lewing commented Jul 29, 2024

This appears to be fixed

@lewing lewing closed this as completed Jul 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

3 participants