Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] benchmark fix aggressive trimming #81037

Merged
merged 5 commits into from
Jan 24, 2023
Merged

[browser] benchmark fix aggressive trimming #81037

merged 5 commits into from
Jan 24, 2023

Conversation

pavelsavara
Copy link
Member

to fix

Uncaught Error: Could not find method: LegacyExportTargetInt
    Ni http://localhost:8270/dotnet.js:5
    mi http://localhost:8270/dotnet.js:5
    init http://localhost:8270/main.js:73
    async* http://localhost:8270/main.js:188```

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jan 23, 2023
@pavelsavara pavelsavara requested a review from lewing as a code owner January 23, 2023 17:40
@ghost ghost assigned pavelsavara Jan 23, 2023
@ghost
Copy link

ghost commented Jan 23, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

to fix

Uncaught Error: Could not find method: LegacyExportTargetInt
    Ni http://localhost:8270/dotnet.js:5
    mi http://localhost:8270/dotnet.js:5
    init http://localhost:8270/main.js:73
    async* http://localhost:8270/main.js:188```

<table>
  <tr>
    <th align="left">Author:</th>
    <td>pavelsavara</td>
  </tr>
  <tr>
    <th align="left">Assignees:</th>
    <td>-</td>
  </tr>
  <tr>
    <th align="left">Labels:</th>
    <td>

`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`

</td>
  </tr>
  <tr>
    <th align="left">Milestone:</th>
    <td>8.0.0</td>
  </tr>
</table>
</details>

radekdoulik
radekdoulik approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara pavelsavara mentioned this pull request Jan 23, 2023
Merged
@lewing lewing merged commit 96d492a into dotnet:main Jan 24, 2023
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
@pavelsavara @radekdoulik @mdh1418
[browser] benchmark fix aggressive trimming (dotnet#81037)
4e8e1a4 
* fix trimming

* revert dotnet#81027

* Fix build

Co-authored-by: Radek Doulik <radekdoulik@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
@pavelsavara pavelsavara deleted the browser_bench_trimming branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radekdoulik radekdoulik radekdoulik approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @radekdoulik @lewing