[browser] benchmark fix aggressive trimming (#81037)

* fix trimming * revert #81027 * Fix build Co-authored-by: Radek Doulik <radekdoulik@gmail.com>
dotnet · Jan 24, 2023 · 96d492a · 96d492a
1 parent 4c992b1
commit 96d492a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/src/mono/sample/wasm/browser-bench/Browser.cs b/src/mono/sample/wasm/browser-bench/Browser.cs
@@ -5,6 +5,8 @@ namespace Sample
 {
     public partial class Test
     {
+        internal const string AssemblyName = "Wasm.Browser.Bench.Sample";
+
         public static int Main(string[] args)
         {
             return 0;

diff --git a/src/mono/sample/wasm/browser-bench/Console/Console.cs b/src/mono/sample/wasm/browser-bench/Console/Console.cs
@@ -11,6 +11,7 @@ namespace Sample
 {
     public partial class Test
     {
+        internal const string AssemblyName = "Wasm.Console.Bench.Sample";
         static string tasksArg;
 
         static List<string> ProcessArguments(string[] args)

diff --git a/src/mono/sample/wasm/browser-bench/JSInterop.cs b/src/mono/sample/wasm/browser-bench/JSInterop.cs
@@ -10,6 +10,7 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Sample
 {
@@ -24,9 +25,9 @@ class JSInteropTask : BenchTask
         public JSInteropTask()
         {
             measurements = new Measurement[] {
-                // new LegacyExportIntMeasurement(),
+                new LegacyExportIntMeasurement(),
                 new JSExportIntMeasurement(),
-                // new LegacyExportStringMeasurement(),
+                new LegacyExportStringMeasurement(),
                 new JSExportStringMeasurement(),
                 new JSImportIntMeasurement(),
                 new JSImportStringMeasurement(),
@@ -41,6 +42,8 @@ public class LegacyExportIntMeasurement : BenchTask.Measurement
         {
             public override int InitialSamples => 3;
             public override string Name => "LegacyExportInt";
+            // because of the aggressive trimming of methods reachable via JS legacy bind_static_method
+            [DynamicDependency(DynamicallyAccessedMemberTypes.PublicMethods, "Sample.ImportsExportsHelper", Test.AssemblyName)]
             public override void RunStep()
             {
                 ImportsExportsHelper.RunLegacyExportInt(10000);
@@ -61,6 +64,9 @@ public class LegacyExportStringMeasurement : BenchTask.Measurement
         {
             public override int InitialSamples => 3;
             public override string Name => "LegacyExportString";
+
+            // because of the aggressive trimming of methods reachable via JS legacy bind_static_method
+            [DynamicDependency(DynamicallyAccessedMemberTypes.PublicMethods, "Sample.ImportsExportsHelper", Test.AssemblyName)]
             public override void RunStep()
             {
                 ImportsExportsHelper.RunLegacyExportString(10000);

diff --git a/src/mono/sample/wasm/browser-bench/main.js b/src/mono/sample/wasm/browser-bench/main.js
@@ -70,10 +70,10 @@ class MainApp {
         setTasks = exports.Sample.Test.SetTasks;
         getFullJsonResults = exports.Sample.Test.GetFullJsonResults;
 
-        // legacyExportTargetInt = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetInt");
-        // jsExportTargetInt = exports.Sample.ImportsExportsHelper.JSExportTargetInt;
-        // legacyExportTargetString = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetString");
-        // jsExportTargetString = exports.Sample.ImportsExportsHelper.JSExportTargetString;
+        legacyExportTargetInt = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetInt");
+        jsExportTargetInt = exports.Sample.ImportsExportsHelper.JSExportTargetInt;
+        legacyExportTargetString = BINDING.bind_static_method("[Wasm.Browser.Bench.Sample]Sample.ImportsExportsHelper:LegacyExportTargetString");
+        jsExportTargetString = exports.Sample.ImportsExportsHelper.JSExportTargetString;
 
         setModuleImports("main.js", {
             Sample: {