-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge main #52156
Merged
Merged
merge main #52156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start implementation of generate ctor intent
- Don't take a cancellation token, since the whole point is not to do expensive work - Just keep fields and parameters in a consistent order
…sions/SymbolExtensions.cs Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
XAML QuickInfo update
Add intellicode API for generating code action edits from intents and
- The LSP specification requires that `signatures` be provided. Currently Roslyn breaks this LSP contract by returning a new signature help item. It should be returning `null`
…tionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129) Switch to using a path to DocumentId cache in the XamlProjectService to avoid unnecessary and sometimes dangerous transitions to the main thread during TrackDocument calls.
Update IDEDiagnosticIDConfigurationTests to be exclusive rather than inclusive
* Move debugging service to debugging session * Remove warnings for edits made while app is running * Open edit sessions for both running and break states * Trigger document reanalysis after EmitSolutionUpdateAsync
- The optimized completion list type offers "fast" serialization (3.7x). - This is dependent upon a VS LSP Platform PR getting in: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/312367 - Update language server protocol package version. Part of dotnet/aspnetcore#30232
Use `null` instead of empty signature helps in LSP
Replace SyntaxTree caching with IDE document state preservation
…nconvertedInterpolatedString (dotnet#52061) This is intended to be a semantics-preserving refactoring that will make later work easier. When an interpolated string is first encountered, we now bind it as a `BoundUnconvertedInterpolatedString` node, and then when we bind to the natural type we convert it to a `BoundInterpolatedString` expression. Future code to allow it to convert to non-string types will take advantage of this in the conversion step.
* upstream/main: (75 commits) Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061) Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834) Use OptimizedVSCompletionList in LSP scenarios. F5 Hot Reload (dotnet#52101) Fix typescript shim Add tests for lazy syntax trees coming from the GeneratorDriver React to code review feedback. Simplify the lazy-initalization pattern used in GetRoot Remove an unnecessary override. (dotnet#52140) Update issue number (dotnet#52130) Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129) Add RestrictedIVT to dotnet watch to Features (dotnet#52087) Don't try to highlight operators (dotnet#52041) Use `null` instead of empty signature helps in LSP Use member type for relational pattern even in error cases (dotnet#51950) Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs Use new QuickInfoUtilities helper Rebuild API shape (dotnet#52079) Added position parameter name Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts. ...
ghost
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default
in SyntaxNode-Update methods #51997 (Fix for: "Information Loss" caused by use of default in SyntaxNode-Update methods #51997 #52036)null
instead of empty signature helps in LSPBoundInterpolatedString
intoBoundInterpolatedString
andBoundUnconvertedInterpolatedString
#52061)