Rebuild API shape #52079
Merged
Rebuild API shape #52079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks up `BuildConstructor` into a simple hierarchy with both CSharp and Visual Basic implementations. The name `CompilationFactory` was chosen after a bit of offline conversation and mostly due to this representing a factory of sorts. As with all other API names it will be reviewed before making this API officially public / shipping. Note: there is no intended functional change with this PR, it is purely just refactoring the API shape around.
jaredpar
added
Area-Compilers
Feature - Rebuild
|
@dotnet/roslyn-compiler, @RikkiGibson PTAL |
RikkiGibson
approved these changes
Mar 23, 2021
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
|
Responded to PR feedback |
RikkiGibson
reviewed
Mar 24, 2021
| public override ParseOptions ParseOptions => CSharpParseOptions; | ||
| public override CompilationOptions CompilationOptions => CSharpCompilationOptions; | ||
| public CSharpParseOptions CSharpParseOptions { get; } | ||
| public CSharpCompilationOptions CSharpCompilationOptions { get; } |
RikkiGibson
approved these changes
Mar 24, 2021
|
@roslyn-compiler can I get a second review on this? |
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
reviewed
Mar 24, 2021
cston
approved these changes
Mar 24, 2021
ghost
added this to the 
Merged
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 25, 2021
* upstream/main: (75 commits) Split BoundInterpolatedString into BoundInterpolatedString and BoundUnconvertedInterpolatedString (dotnet#52061) Combine VB comparers into one, and combine VB and C# comparers together (dotnet#51834) Use OptimizedVSCompletionList in LSP scenarios. F5 Hot Reload (dotnet#52101) Fix typescript shim Add tests for lazy syntax trees coming from the GeneratorDriver React to code review feedback. Simplify the lazy-initalization pattern used in GetRoot Remove an unnecessary override. (dotnet#52140) Update issue number (dotnet#52130) Enable CodeActions support for XAML using its own provider and CodeActionCache. The handlers are actually shared with Roslyn as is. (dotnet#52129) Add RestrictedIVT to dotnet watch to Features (dotnet#52087) Don't try to highlight operators (dotnet#52041) Use `null` instead of empty signature helps in LSP Use member type for relational pattern even in error cases (dotnet#51950) Update src/VisualStudio/Xaml/Impl/Implementation/LanguageServer/Extensions/SymbolExtensions.cs Use new QuickInfoUtilities helper Rebuild API shape (dotnet#52079) Added position parameter name Updated XAML QuickInfo to show more info like C# by using ISymbolDisplayService and adding more documentation parts. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks up
BuildConstructorinto a simple hierarchy with bothCSharp and Visual Basic implementations. The name
CompilationFactorywas chosen after a bit of offline conversation and mostly due to this
representing a factory of sorts. As with all other API names it will be
reviewed before making this API officially public / shipping.
Note: there is no intended functional change with this PR, it is purely
just refactoring the API shape around.