Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite xunit's app domain handling to not call AppDomain.Unload #49355

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Overwrite xunit's app domain handling to not call AppDomain.Unload #49355

merged 4 commits into from
Nov 13, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Nov 13, 2020 •
edited
Loading

Hoping this avoids the need to maintain our own copy of the xunit runners, by patching the implementation at runtime to apply xunit/xunit#2192.

Fixes #15497
Fixes #40369
Fixes #48989
Fixes #49024
Fixes #49035
Fixes #49275

@sharwell sharwell marked this pull request as ready for review November 13, 2020 18:26
@sharwell sharwell requested a review from a team as a code owner November 13, 2020 18:26
CyrusNajmabadi
CyrusNajmabadi approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with this as long as we have a comment linking to wahtever issue/pr we raised on the xunit side that we couldn't effectivel move forward with.

@sharwell sharwell merged commit 1d720f4 into dotnet:master Nov 13, 2020
@ghost ghost added this to the Next milestone Nov 13, 2020
@sharwell sharwell deleted the no-dispose branch November 13, 2020 23:15
@jaredpar
Copy link
Member

jaredpar commented Nov 17, 2020 •
edited
Loading

This is beautiful evil

@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
16.9.P2
6 participants
@sharwell @jaredpar @jasonmalinowski @CyrusNajmabadi @allisonchou @Dotnet-GitSync-Bot