Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn unit tests failing during xUnit AppDomain unload combined with vs-threading FailFast #49275

Closed
jasonmalinowski opened this issue Nov 10, 2020 · 0 comments · Fixed by #49355
Closed

Roslyn unit tests failing during xUnit AppDomain unload combined with vs-threading FailFast #49275

jasonmalinowski opened this issue Nov 10, 2020 · 0 comments · Fixed by #49355
Assignees
@jasonmalinowski
Labels
Area-Infrastructure Flaky Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI

Comments

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Nov 10, 2020 •
edited by runfoapp bot
Loading

When Roslyn unit tests shut down, xUnit unloads the AppDomain that our tests are loaded into. This means that the test threads inside the AppDomain are unloaded, which is done by aborting the threads. This triggers this FailFast here:

https://github.com/microsoft/vs-threading/blob/a2c873656dd7a7967499595a4587cee7b71ff4b4/src/Microsoft.VisualStudio.Threading/JoinableTaskFactory.cs#L968-L974

which causes the entire test process to crash.

This is a tracking bug so I can link failures in other PRs to it as I find them.

Build Kind Start Time
884749 Rolling 2020-12-11
883904 Rolling 2020-12-11
884283 Rolling 2020-12-11
881332 Rolling 2020-10-11
881863 Rolling 2020-11-11
883303 Rolling 2020-11-11
884395 PR 49271 2020-12-11
@jasonmalinowski jasonmalinowski self-assigned this Nov 10, 2020
@jasonmalinowski jasonmalinowski mentioned this issue Nov 10, 2020
Merged
@jasonmalinowski jasonmalinowski added Flaky Test Test failures in roslyn-CI labels Nov 10, 2020
@maryamariyan maryamariyan added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 11, 2020
@sharwell sharwell added Area-Infrastructure Resolution-External The behavior lies outside the functionality covered by this repository and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 12, 2020
@sharwell sharwell mentioned this issue Nov 13, 2020
Merged
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed Resolution-External The behavior lies outside the functionality covered by this repository labels Nov 13, 2020
@sharwell sharwell mentioned this issue Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-Infrastructure Flaky Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overwrite xunit's app domain handling to not call AppDomain.Unload sharwell/roslyn
3 participants
@jasonmalinowski @sharwell @maryamariyan