Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to master-vs-deps #48835

Merged
34 commits merged into from
Oct 22, 2020
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into master-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

sharwell and others added 30 commits May 21, 2020 20:41
This change ensures the main thread is not blocked by high-priority
continuations while low priority operations are pending without an
explicit event processing action.
This change ensures asynchronous operations in "earlier" stages which
are triggered by later stages still cause the test to wait for full
completion. The wait is complete when reaching a state where no pending
tasks are in any category of interest.

Fixes #48671
Use an iterative wait in DiagnosticTaggerWrapper
Move to thread pool after yield in WaitAllAsync
Fix official build in dnceng
* Restore retry on integration tests

The retry mechanism on integration tests is predicated on not having the
`--html` option passed to RunTests. PR #48686 changed it to be
unconditionally passed which ended up breaking retry. Undoing the
unconditional passing of `--html` to fix retry.
Move VisualStudioTaskSchedulerProvider to the EditorFeatures layer
Run integration tests on scouting queue
allisonchou and others added 4 commits October 21, 2020 17:30
Simplify generate-constructor logic for delegated constructors.
Remove inline tags when edits intersect them.
[LSP] Disable signature help in cloud scenario
@dotnet-bot dotnet-bot requested review from a team as code owners October 22, 2020 03:03
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 22, 2020

Hello @dotnet-bot!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit df19ae8 into master-vs-deps Oct 22, 2020
@ghost ghost deleted the merges/master-to-master-vs-deps branch October 22, 2020 20:39
@ghost ghost added this to the Next milestone Oct 22, 2020
@dotnet-bot dotnet-bot restored the merges/master-to-master-vs-deps branch October 22, 2020 21:03
@dotnet-bot dotnet-bot deleted the merges/master-to-master-vs-deps branch October 22, 2020 21:03
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants