Fix official build in dnceng #48809
Merged
Fix official build in dnceng #48809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
JoeRobich
approved these changes
Oct 21, 2020
MattGal
approved these changes
Oct 21, 2020
azure-pipelines-official.yml
Outdated
| inputs: | ||
| dropServiceURI: 'https://devdiv.artifacts.visualstudio.com' | ||
| buildNumber: 'ProfilingInputs/DevDiv/$(Build.Repository.Name)/$(SourceBranchName)/$(Build.BuildNumber)' | ||
| sourcePath: '$(Build.SourcesDirectory)\artifacts\OptProf\$(BuildConfiguration)\Data' | ||
| toLowerCase: false | ||
| usePat: false | ||
| retentionDays: 90 | ||
| detailedLog: true |
There was a problem hiding this comment.
did you mean to leave this here? (probably fine but looks like it was there to debug)
There was a problem hiding this comment.
Yea it was for debug, but I think 100 extra lines of drop.exe log is OK :)
Removed
|
Hello @genlu! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now works end to end
https://dev.azure.com/dnceng/internal/_build/results?buildId=860938&view=results
FYI @dotnet/roslyn-infrastructure @MattGal