CV macro with stratification column doesn't work #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
reviewed
May 23, 2018
| var importInput = new ML.Data.TextLoader(dataPath); | ||
| importInput.Arguments.Column = new ML.Data.TextLoaderColumn[] | ||
| { | ||
| new ML.Data.TextLoaderColumn { Name = "Label", Source = new[] { new ML.Data.TextLoaderRange { Min = 0, Max = 0 } }, Type = DataKind.R4 }, |
There was a problem hiding this comment.
ML.Data.TextLoaderRange [](start = 88, length = 23)
I think for these scalar columns you can just use the simpler new ML.Data.TextLoaderRange(0) constructor. #Resolved
|
I see why this is a necessary change, but is there an issue we could link, possibly with more details of the problem? Otherwise looks good. Edit: Now referring to an issue thanks Yael! #Resolved |
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* Reduce number of hash bits in stratification column and add a unit test. * Address PR comments.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stratification column is being hashed to too many hash bits, and the RangeFilter that does the stratified split can't do the split. We reduce number of hash bits in stratification column so that the RangeFilter can split the data.
Fixes #182 .