Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Blazor] Update selenium versions" #50556

Merged

Conversation

captainsafia
Copy link
Member

Reverts #50511 to unblock builds.

@captainsafia captainsafia requested review from a team and wtgodbe as code owners September 6, 2023 16:53
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 6, 2023
@ghost
Copy link

ghost commented Sep 6, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@adityamandaleeka adityamandaleeka merged commit 564a94d into release/8.0 Sep 6, 2023
@adityamandaleeka adityamandaleeka deleted the revert-50511-javiercn/update-selenium-version branch September 6, 2023 18:13
@ghost ghost added this to the 8.0-rc2 milestone Sep 6, 2023
captainsafia added a commit that referenced this pull request Sep 14, 2023
mkArtakMSFT pushed a commit that referenced this pull request Sep 15, 2023
* Support resolving IFormFile in complex form mapping

* Feedback

* Fix up FormFile integration in Blazor

* Fix up FileConverter interfaces

* Fix build

* Fix FormFileCollection initialization

* Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)"

This reverts commit 564a94d.

* Update test for non-enhanced form

* Revert "Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)""

This reverts commit 78bf7d8.

* Add support for IReadOnlyList<IBrowserFile>
javiercn added a commit that referenced this pull request Sep 16, 2023
javiercn added a commit that referenced this pull request Sep 17, 2023
javiercn added a commit that referenced this pull request Sep 18, 2023
javiercn added a commit that referenced this pull request Sep 18, 2023
javiercn added a commit that referenced this pull request Sep 18, 2023
@SteveSandersonMS
Copy link
Member

With changes like this it would be great to put more details in the PR. There's nothing explaining what was broken about the old approach, nor even error messages from failing builds, so anyone trying to do a better job of the update has to do the investigation again from scratch and risks making the same mistakes again.

@captainsafia @javiercn Could you add some details here please?

@javiercn
Copy link
Member

@SteveSandersonMS I don't remember the exact details other than some tests failing on the CI, I suspect the version on the CI old and that was causing issues.

I did another update to this to account for Chrome 117 and I am going to send a PR to main to see if we can capture more details about the version running on CI

@captainsafia
Copy link
Member Author

@SteveSandersonMS I pulled out the stack trace from one of the failing builds that originally prompted this revert.

[Test Class Cleanup Failure (Microsoft.AspNetCore.Components.E2ETest.Tests.SignalRClientTest)]: System.InvalidOperationException : Couldn't create a Selenium remote driver client. The server is irresponsive
---- System.InvalidOperationException : Could not start a new session. Error while creating session with the driver service. Stopping driver service: Could not start a new session. Response code 500. Message: unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /opt/google/chrome/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) 
Host info: host: 'fv-az98-329', ip: '10.1.40.0'
Build info: version: '4.12.0', revision: '249f2a7d1b*'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1042-azure', java.version: '11.0.20'
Driver info: driver.version: unknown
Build info: version: '4.12.0', revision: '249f2a7d1b*'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1042-azure', java.version: '11.0.20'
Driver info: driver.version: unknown (SessionNotCreated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants