-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Blazor] Update selenium versions" #50556
Revert "[Blazor] Update selenium versions" #50556
Conversation
This reverts commit 2772a78.
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
* Support resolving IFormFile in complex form mapping * Feedback * Fix up FormFile integration in Blazor * Fix up FileConverter interfaces * Fix build * Fix FormFileCollection initialization * Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)" This reverts commit 564a94d. * Update test for non-enhanced form * Revert "Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)"" This reverts commit 78bf7d8. * Add support for IReadOnlyList<IBrowserFile>
With changes like this it would be great to put more details in the PR. There's nothing explaining what was broken about the old approach, nor even error messages from failing builds, so anyone trying to do a better job of the update has to do the investigation again from scratch and risks making the same mistakes again. @captainsafia @javiercn Could you add some details here please? |
@SteveSandersonMS I don't remember the exact details other than some tests failing on the CI, I suspect the version on the CI old and that was causing issues. I did another update to this to account for Chrome 117 and I am going to send a PR to main to see if we can capture more details about the version running on CI |
@SteveSandersonMS I pulled out the stack trace from one of the failing builds that originally prompted this revert.
|
Reverts #50511 to unblock builds.