[Blazor] Update selenium versions #50511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
javiercn
commented
Sep 4, 2023
javiercn
commented
Sep 4, 2023
| @@ -85,7 +85,7 @@ public static async Task<SeleniumStandaloneServer> GetInstanceAsync(ITestOutputH | |||
| private static async Task InitializeInstance(ITestOutputHelper output) | |||
| { | |||
| var port = FindAvailablePort(); | |||
| var uri = new UriBuilder("http", SeleniumHost, port, "/wd/hub").Uri; | |||
| var uri = new UriBuilder("http", SeleniumHost, port).Uri; | |||
There was a problem hiding this comment.
This URI no longer exists in Selenium 4.12.0
javiercn
commented
Sep 4, 2023
javiercn
commented
Sep 4, 2023
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "version": "4.12.0", | |||
There was a problem hiding this comment.
Uses Selenium 4.12.0, the default version is 4.9.0
javiercn
force-pushed
the
javiercn/update-selenium-version
branch
from
8d604a8 to
84cc15e
Compare
surayya-MS
approved these changes
Sep 4, 2023
mkArtakMSFT
approved these changes
Sep 4, 2023
5 tasks
|
Nice |
|
@mkArtakMSFT can you squash and merge this? |
ghost
added this to the 
| "devDependencies": { | ||
| "sauce-connect-launcher": "^1.3.1", | ||
| "selenium-standalone": "^9.1.1", |
There was a problem hiding this comment.
Does this mean https://github.com/dotnet/aspnetcore-internal/blob/main/docs/operations/selenium_update.md should be updated?
captainsafia
added a commit
that referenced
this pull request
Sep 6, 2023
This reverts commit 2772a78.
adityamandaleeka
pushed a commit
that referenced
this pull request
Sep 6, 2023
captainsafia
added a commit
that referenced
this pull request
Sep 14, 2023
captainsafia
added a commit
that referenced
this pull request
Sep 14, 2023
mkArtakMSFT
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Support resolving IFormFile in complex form mapping * Feedback * Fix up FormFile integration in Blazor * Fix up FileConverter interfaces * Fix build * Fix FormFileCollection initialization * Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)" This reverts commit 564a94d. * Update test for non-enhanced form * Revert "Revert "Revert "[Blazor] Update selenium versions (#50511)" (#50556)"" This reverts commit 78bf7d8. * Add support for IReadOnlyList<IBrowserFile>
javiercn
added a commit
that referenced
this pull request
Sep 16, 2023
javiercn
added a commit
that referenced
this pull request
Sep 17, 2023
javiercn
added a commit
that referenced
this pull request
Sep 18, 2023
javiercn
added a commit
that referenced
this pull request
Sep 18, 2023
javiercn
added a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our selenium infrastructure to one that is compatible with the new chrome for testing feature.