Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing returns in EnableAuthenticator #40040

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Add missing returns in EnableAuthenticator #40040

merged 2 commits into from
Feb 7, 2022

Conversation

danirzv
Copy link
Contributor

@danirzv danirzv commented Feb 7, 2022

Add missing returns in EnableAuthenticator

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fixes #39909

@danirzv danirzv requested a review from Pilchie as a code owner February 7, 2022 16:33
@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Feb 7, 2022
@dnfadmin
Copy link

dnfadmin commented Feb 7, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

adityamandaleeka
adityamandaleeka approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @HaoK

@HaoK
Copy link
Member

HaoK commented Feb 7, 2022

Thanks @danirzv !

@HaoK HaoK merged commit 7c554b7 into dotnet:main Feb 7, 2022
@ghost ghost added this to the 7.0-preview2 milestone Feb 7, 2022
@HaoK
Copy link
Member

HaoK commented Feb 7, 2022

Hey @danirzv if you are interested in making another PR, these changes also need to be applied on the scaffolding side so they show up when people Add identity to their projects: See https://github.com/dotnet/Scaffolding/blob/main/src/Scaffolding/VS.Web.CG.Mvc/Templates/Identity/Bootstrap5/Pages/Account/Manage/Account.Manage.EnableAuthenticator.cs.cshtml#L109

@danirzv danirzv deleted the patch-1 branch February 7, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@HaoK HaoK HaoK approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@HaoK HaoK

Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0-preview2
Development

Successfully merging this pull request may close these issues.

EnableAuthenticatorModel shows page even if user was not found
4 participants
@danirzv @dnfadmin @HaoK @adityamandaleeka