Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableAuthenticatorModel shows page even if user was not found #39909

Closed
1 task done
CatoLeanTruetschel opened this issue Feb 1, 2022 · 5 comments · Fixed by #40040
Closed
1 task done

EnableAuthenticatorModel shows page even if user was not found #39909

CatoLeanTruetschel opened this issue Feb 1, 2022 · 5 comments · Fixed by #40040
Labels
area-identity Includes: Identity and providers ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue

Comments

@CatoLeanTruetschel
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The EnableAuthenticator shows the page even if the respective user was not found. There seems to be a return missing in the check here.

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@javiercn javiercn added the area-identity Includes: Identity and providers label Feb 1, 2022
@Tratcher Tratcher added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Feb 4, 2022
@Tratcher Tratcher added this to the .NET 7 Planning milestone Feb 4, 2022
@ghost
Copy link

ghost commented Feb 4, 2022

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@HaoK
Copy link
Member

HaoK commented Feb 7, 2022

Keeping this open until the scaffolding side is done as well

@HaoK HaoK reopened this Feb 7, 2022
@danirzv
Copy link
Contributor

danirzv commented Feb 7, 2022

@HaoK I've sent a PR for it a moment ago.
dotnet/Scaffolding#1819

@HaoK
Copy link
Member

HaoK commented Feb 7, 2022

Awesome closing this out as fixed now

@HaoK HaoK closed this as completed Feb 7, 2022
@HaoK HaoK added the ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! label Feb 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-identity Includes: Identity and providers ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants