Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to dotnet/installer/main@19943da 6.0.100-rc.1.21372.10 #6110

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Bump to dotnet/installer/main@19943da 6.0.100-rc.1.21372.10 #6110

merged 3 commits into from
Jul 23, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 21, 2021 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.6.21366.2 to 6.0.100-preview.6.21370.1 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21368.1 to 6.0.0-rc.1.21372.1 (parent: Microsoft.Dotnet.Sdk.Internal)

From https://github.com/dotnet/installer

  • Subscription: 6548876b-06a1-4ab6-a5a5-08d8ed868088
  • Build: 20210722.10
  • Date Produced: 7/22/2021 6:55 PM
  • Commit: 19943da31a3470cf59f363f46956edd8a8451af8
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
a2a26ab 
…210721.4

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-rc.1.21369.3 -> To Version 6.0.100-rc.1.21371.4

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21366.2 -> To Version 6.0.100-preview.6.21370.1 (parent: Microsoft.Dotnet.Sdk.Internal
@jonpryor
Copy link
Member

jonpryor commented Jul 22, 2021 •
edited
Loading

Looks like something in the dotnet/installer bump, dotnet/runtime bump, or the mono/linker bump broke satellite assembly handling.

The MissingSatelliteAssemblyInApp test is failing:

Apk should contain satellite assemblies!
Expected: True
But was:  False

@jonpryor jonpryor mentioned this pull request Jul 22, 2021
Merged
@jonpryor
Copy link
Member

Hypothesis, in a "please may I be wrong" perspective…

Consider SatelliteAssembly.TryGetSatelliteCultureAndFileName(): https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/src/Xamarin.Android.Build.Tasks/Utilities/SatelliteAssembly.cs

SatelliteAssembly uses regular expressions.

The dotnet/runtime bump contains changes to regular expressions: dotnet/runtime@7eb749c

Did our use of regular expressions break? I need an actual test. :-/

@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
f7d2b08 
…210722.10

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-rc.1.21369.3 -> To Version 6.0.100-rc.1.21372.10

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21366.2 -> To Version 6.0.100-preview.6.21370.1 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

@jonpryor they have reverted a regex change: dotnet/runtime@3847790

I triggered Maestro again, because this change seems to be in the current dotnet/installer build.

@jonathanpeppers jonathanpeppers changed the title [main] Update dependencies from dotnet/installer Bump to dotnet/installer/main@19943da 6.0.100-rc.1.21372.10 Jul 23, 2021
@jonathanpeppers jonathanpeppers merged commit 96eb449 into main Jul 23, 2021
@jonathanpeppers jonathanpeppers deleted the darc-main-67352ca4-400f-4ac8-a1b0-176ca76cfe34 branch July 23, 2021 12:13
thaystg added a commit to thaystg/xamarin-android that referenced this pull request Jul 23, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_dont_use_debugg…
997135f 
…er_unhandled_exception

* origin/main:
  Bump to dotnet/installer@19943da 6.0.100-rc.1.21372.10 (dotnet#6110)
  [xaprepare] don't install microsoft-net-runtime-android workload (dotnet#6114)
  [Mono.Android] Use `mono_unhandled_exception` for NET6 (dotnet#6104)
  Bump to dotnet/installer@9c463710 6.0.100-rc.1.21369 (dotnet#6072)
  Bump to xamarin/xamarin-android-binutils/2.37-XA.1@77618674 v2.37 (dotnet#6096)
  [Mono.Android.Export] Fix DynamicDependency to JavaArray (dotnet#6105)
  [xaprepare] always delete ~/android-toolchain/dotnet (dotnet#6098)
  [CI] Add nuget to msi conversion and VS insert stage (dotnet#6030)
  [build] delete platform-31 folder on test jobs (dotnet#6103)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

@pjcollins pjcollins Awaiting requested review from pjcollins pjcollins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonpryor @jonathanpeppers