[CI] Add nuget to msi conversion and VS insert stage #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
changed the title
This reverts commit 840cfbc.
This reverts commit cf6520d. Conflicts: src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Jul 19, 2021
VS doesn't support these either, and they aren't included in the |
jonpryor
pushed a commit
that referenced
this pull request
Jul 20, 2021
Context: xamarin/yaml-templates#117 A new CI job and stage have been added to facilitate the Visual Studio installer insertion process. The first job named "Convert NuGet to MSI" will convert signed packages to `.msi` installers, and generate Visual Studio manifests for the `.msi` installers. The `.msi` files are signed and converted back to `.nupkg` files for the Windows command line install scenario. These packages are uploaded as pipeline artifacts named `vsdrop-signed`, and `vs-msi-nugets`. The new `vs-workload.props` file contains version information and other metadata used by the convert job to generate a Visual Studio manifest. The `@(ShortNames)` item group is used to avoid path length issues that can arise due to the way VS caches some components when building. The `.msi` conversion tooling uses this to replace strings in the VS component file names and IDs generated for our workload packs. In some cases the semver label generated for our packs can be long, so we replace the full semver version with a more predictable four part version (30.0.100.x). The new "VS Insertion" stage starts with a [manual validation task][0]. This task will pause execution and wait for someone to click a "Resume" or "Reject" button that will appear on the pipeline UI. This task is configured to be rejected after waiting for two days, but it can be manually re-ran any time after being rejected to trigger a VS insertion for an older build. To access the Reume or Reject button, go to the Pipelines page for the commit to be approved, e.g.: 1. https://github.com/xamarin/xamarin-android/commits/main 2. Click the ✅ or ❌ for the commit of interest. This displays an "All checks have passed" or "Some checks were not successful" overlay. 3. Click the **Details** link for **Xamarin.Android** within the overlay shown by (2). 4. At the bottom of the "runs" page, click the **View more details on Azure Pipelines** link. When the manual validation task is approved, a VS Drop will be created containing all .NET 6 `.msi` files. This Drop URL can then be used to update our component versions in Visual Studio. This last piece is currently manual as we will initially be introducing new components, however we should be able to automate VS PR creation in the future. [0]: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/manual-validation?view=azure-devops&tabs=yaml
thaystg
added a commit
to thaystg/xamarin-android
that referenced
this pull request
Jul 23, 2021
…er_unhandled_exception * origin/main: Bump to dotnet/installer@19943da 6.0.100-rc.1.21372.10 (dotnet#6110) [xaprepare] don't install microsoft-net-runtime-android workload (dotnet#6114) [Mono.Android] Use `mono_unhandled_exception` for NET6 (dotnet#6104) Bump to dotnet/installer@9c463710 6.0.100-rc.1.21369 (dotnet#6072) Bump to xamarin/xamarin-android-binutils/2.37-XA.1@77618674 v2.37 (dotnet#6096) [Mono.Android.Export] Fix DynamicDependency to JavaArray (dotnet#6105) [xaprepare] always delete ~/android-toolchain/dotnet (dotnet#6098) [CI] Add nuget to msi conversion and VS insert stage (dotnet#6030) [build] delete platform-31 folder on test jobs (dotnet#6103)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/yaml-templates/pull/117
A new CI job and stage have been added to facilitate the Visual Studio
installer insertion process.
The first job named "Convert NuGet to MSI" will convert signed packages
to .msi installers, and generate Visual Studio manifests for the .msi
installers. The .msi files are signed and converted back to .nupkg
files for the Windows command line install scenario. These packages are
uploaded as pipeline artifacts named
vsdrop-signed, andvs-msi-nugets.The new
vs-workload.propsfile contains version information and othermetadata used by the convert job to generate a Visual Studio manifest.
The
ShortNamesitem in this file is used to avoid path length issuesthat can arise due to the way VS caches some components when building.
The .msi conversion tooling uses this to replace strings in the VS
component file names and IDs generated for our workload packs. In
some cases the semver label generated for our packs can be long, so
we replace the full semver version with a more predictable four part
version (30.0.100.x).
The new "VS Insertion" stage starts with a manual validation task.
This task will pause execution and wait for someone to click a "Resume"
or "Reject" button that will appear on the pipeline UI. This task is
configured to be rejected after waiting for two days, but it can be
manually re-ran any time after being rejected to trigger a VS insertion
for an older build.
If the manual validation task is approved, a VS Drop will be created
containing all .NET 6 .msi files. This Drop URL can then be used to
update our component versions in Visual Studio. This last piece is
currently manual as we will initially be introducing new components,
however we should be able to automate VS PR creation in the future.