Fix issue #850, Warn user of filter when pruning #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append a warning with which filter the elements will be pruned with if filter is set. Signed-off-by: Justyn Temme <justyntemme@gmail.com>
justyntemme
changed the title
|
ping @vdemeester PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append a warning with which filter the elements will be pruned with if filter is set.
This is a fix for issue #850
- What I did
Added a message in prune warning if filter is applied.
- How I did it
I have checked the length of the string of the options.prune argument, and appended the warning along with the string value of that arguments supplied.
- How to verify it
docker system prune --filter=label=foo
- Description for the changelog
Added warning to prune command when filter is applied.
- A picture of a cute animal (not mandatory but encouraged)
My icon :)