-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker system prune warn message should display filters if any #850
Comments
@vdemeester Does an output like the following look OK?
|
Also it seems that volume, image, and container prune commands do not display the filter either. |
@vdemeester I have opened a PR to address this request. Please let me know if we would like to implement this any different way. |
Fix issue #850, Warn user of filter when pruning
The merged MR doesn't seem to be in effect anymore? https://github.com/docker/cli/blob/master/cli/command/system/prune.go It is quite jarring that the warning shouts "ALL" when I've applied a filter. |
Filters are printed as part of the template at https://github.com/docker/cli/blob/master/cli/command/system/prune.go#L57 But not all objects (volumes, networks, containers, images) accept the same set of filters |
Shouldn't the filter be displayed here? |
Description
When running a system prune with filter, the warning message doesn't reflect that the filter will be used.
We should display that the elements pruned will be filtered.
Describe the results you received:
Describe the results you expected:
Same message but that acknowledge the filtering.
The text was updated successfully, but these errors were encountered: