Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate numcores option for resubmit on CRABServer side #8932

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aspiringmind-code
Copy link
Contributor

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 3 warnings
    • 18 comments to review
  • Pycodestyle check: succeeded
    • 77 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2377/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member

Now we need a proper timeline of when changes can be merged, tagged, deployed. Since we can't make this change in TW until the extra option is removed from Client. But may want to do other changes, so merging in master may not be ideal.

@belforte
Copy link
Member

Also, I'd like to review code which has been tested, if possible.

@aspiringmind-code
Copy link
Contributor Author

Put on hold for now.

@aspiringmind-code aspiringmind-code marked this pull request as draft February 17, 2025 15:01
@belforte belforte added Status: On Hold PR: do not merge This PR is a work in progress and not ready to be merged labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: do not merge This PR is a work in progress and not ready to be merged Status: On Hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants