Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate --numcores option for crab resubmit #5369

Closed
belforte opened this issue Feb 13, 2025 · 4 comments · Fixed by #5373
Closed

deprecate --numcores option for crab resubmit #5369

belforte opened this issue Feb 13, 2025 · 4 comments · Fixed by #5373
Assignees

Comments

@belforte
Copy link
Member

belforte commented Feb 13, 2025

  1. it does not work . ref
  2. it makes no sense. We enforce that numCores is equal to numThreads in PSet and PSet can't be changed at resubmit time.

It is not a matter of "giving a few jobs a kick" like with --maxmemory or --maxjobruntime

@belforte
Copy link
Member Author

Hi @aspiringmind-code . I think it is good for you to start putting your hands in CRABClient. Action is simple here: remove the option and all related code.
Starting point:

self.parser.add_option('--numcores',

A bit more work will be to clean up by removing support for this option in CRAB Server and DagmanResubmitter

@aspiringmind-code
Copy link
Contributor

@belforte On the CRABServer side, would we also like to remove tm_numcores column from the Task table?

@belforte
Copy link
Member Author

of course not. num_cores is needed when submitting. Simply it can't be changed afterwards, like most of the values in the Task table.

@aspiringmind-code
Copy link
Contributor

I see, understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants